Thanks, this is a known issue for a long time, we will look into that!! cc @andylizf , and can you fix the lint error here?

The macOS-13 CI jobs show as 'cancelled' rather than 'failed' - this appears to be a GitHub Actions runner issue, not a code problem. All other builds (macos-14, macos-15, ubuntu) passed successfully.

Could you please re-run the cancelled macOS-13 jobs?

Sure, I will do that later, sorry for the late responses since I was on vacation. And thanks again for your contribution!

No worries, thanks for re-running the CI! Let me know if there's anything else that needs to be addressed.

Thanks for implementing this warmup feature! The functionality looks good and solves a real latency problem.

A few suggestions for potential future improvements (not blocking for this PR):

1. Extract common warmup logic

The warmup code in hnsw_embedding_server.py and diskann_embedding_server.py is duplicated. Consider extracting to a shared module:

# leann/warmup.py
def warmup_embedding_model(model_name: str, embedding_mode: str, provider_options=None) -> float:
    """Pre-load embedding model by computing a dummy embedding."""
    ...

2. Clarify enable_warmup semantics

Currently enable_warmup in LeannSearcher controls two things:

• Server-side model preloading
• Client-side dummy query

Consider separating these concerns in a future refactor.

3. Avoid calling private methods

LeannSearcher.warmup() calls self.backend_impl._ensure_server_running(). Consider exposing a public interface for this.

These are minor design notes - the PR is good to merge as-is. Nice work! 🎉

What do you think? @yichuan-w